Merge branch 'v2.3.1_qc_empty_getstate' into 'v2.3.3_qc' (merge request !40)

fix: update rwset comments --bug=0 fix: update rwset comments --bug=0

Merge branch 'v2.3.1_qc_empty_getstate' into 'v2.3.3_qc' (merge request !40)
fix: update rwset comments --bug=0 fix: update rwset comments --bug=0
c21c7bce · tianle · d1cb4e50 · 014ff22c · c21c7bce
Commit c21c7bce authored Feb 08, 2023 by tianle
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 0 deletions

sandbox/tx_handler.go sandbox/tx_handler.go +6 -0

No files found.
--- a/sandbox/tx_handler.go
+++ b/sandbox/tx_handler.go
@@ -195,6 +195,12 @@ func (h *TxHandler) handleTxRequest(msg *protogo.DockerVMMessage) error {
 		txResponse.Events = responseEvents

 	} else {
+		// If tx failed, we don't need to return wset and rset:
+		// - wset: wset is always dropped for fail
+		// - rset: rset can not be dropped for fail
+		//  - from simContext: simContext already has such keys, value is not important
+		//  - from wset: simContext don't have such keys, but it will not cause conflict for applying simContext,
+		//               because even if other txs are written first, the read set here will eventually be dropped
 		txResponse.Code = protogo.DockerVMCode_FAIL
 		txResponse.Result = []byte(response.Message)
 		txResponse.Message = "Fail"